Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] Add warnings to all SDK example apps that would check if propper credentials have been set or it still has the defaults. #473

Merged
merged 9 commits into from
Jan 29, 2024
Merged

[Web] Add warnings to all SDK example apps that would check if propper credentials have been set or it still has the defaults. #473

merged 9 commits into from
Jan 29, 2024

Conversation

arifBurakDemiray
Copy link
Member

No description provided.

turtledreams
turtledreams requested changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@turtledreams turtledreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you turn them into console.warn pls 🙏 maybe 1 indent issue also

turtledreams
turtledreams requested changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@turtledreams turtledreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ind3ntation still messy in some

@ArtursKadikis ArtursKadikis merged commit 503d282 into staging Jan 29, 2024
3 of 5 checks passed
@ArtursKadikis ArtursKadikis deleted the warn_defs branch January 29, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turtledreams turtledreams Awaiting requested review from turtledreams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arifBurakDemiray @turtledreams @ArtursKadikis